Skip to content

fix: incorrect type for document snapshop in Firestore auth triggers #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix: incorrect type for document snapshop in Firestore auth triggers #212

merged 3 commits into from
Jul 12, 2024

Conversation

exaby73
Copy link
Contributor

@exaby73 exaby73 commented Jul 3, 2024 •
edited
Loading

Fixes #207

cabljac
cabljac requested changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but is the print statement meant to be left in?

@exaby73 exaby73 merged commit 9481fe8 into main Jul 12, 2024
@exaby73 exaby73 deleted the fix/207_incorrect-type-in-auth-context-triggers branch July 12, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabljac cabljac cabljac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with Firestore Trigger on_document_created_with_auth_context
2 participants
@exaby73 @cabljac